Feature/time aware transit networks #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts and docstrings
…mat() with unit test
…mes_int to both be True for clarity
…xisting_stop_times_int are used, remove ValueError that can never happen
…e and unique_trip_id records to aid in debugging
… and fix rare case where index was removed before merge
… accept new GTFS modes 11 and 12, validate inputs, update docstring, add prints
…dd calendar and calendar_dates as optional tables
…dd calendar and calendar_dates as optional tables
smmaurer
approved these changes
Apr 27, 2021
Base automatically changed from
maintenance/gtfs-network-refactor-w-unit-tests
to
dev
April 29, 2021 22:14
…pport partial hr time pad values
|
This is great! Thanks @sablanchard |
# Conflicts: # urbanaccess/gtfs/network.py # urbanaccess/tests/test_gtfs_network.py
smmaurer
approved these changes
May 19, 2021
There was a problem hiding this comment.
Looks great! Tests are still failing on Travis in Python 2.7 and 3.5 because Conda isn't able to solve the environment, though.
Discussed this offline, and our feeling is that we should just end support for these platforms. They've been EOL'd, and users can always continue using older versions of UrbanAccess if they need to. See also UDST/udst-planning#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge PR #86 first before this one.
New feature: Adds the optional ability to include arrival and departure times in the generated network. Adds the optional ability to pad the end time range when subsetting a transit network in order to extend your active transit network beyond the specified operational time range. Changed the selection of transit network stops and trips from > and < time range to >= and <= time range in order to explicitly include stop times that also equal the min and max time range - Note: this change will produce slightly larger transit networks than prior versions. Big thanks to @bouzaghrane for his initial PR #83 that started the features in this PR and his input on implementation and use cases. Simple use case demo notebook that illustrates this new functionality will be added in a future update.
Begins to address feature request described in: #78 and #51
Details on changes:
timerange_pad: number of hours, minutes, seconds to pad after the end of the time interval specified in 'timerange'time_aware: boolean to indicate whether the transit network should include time information. If True, 'arrival_time' and 'departure_time' columns from the stop_times table will be included in the transit edge table where 'departure_time' is the departure time at node_id_from stop and 'arrival_time' is the arrival time at node_id_to stop